Arm backend: Remove no_target substring for pytests by martinlsm · Pull Request #18769 · pytorch/executorch

martinlsm · 2026-04-08T11:35:53Z

Pytest cases in the Arm backend no longer requires a no_target substring for test_arm_baremetal.sh to match and run them. Remove this identifier for all the tests.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Pytest cases in the Arm backend no longer requires a no_target substring for test_arm_baremetal.sh to match and run them. Remove this identifier for all the tests. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I21025dd4a2530d37ae88fc6dea88e7591488952e

pytorch-bot · 2026-04-08T11:35:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18769

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 5 Unrelated Failures

As of commit 438b600 with merge base 137dedc ():

NEW FAILURES - The following jobs have failed:

pull / unittest-editable / macos / macos-job (gh)
export/tests/test_target_recipes.py::TestTargetRecipes::test_mv3_model
trunk / test-huggingface-transformers-macos (distilbert|coreml_fp32_gpu|--quantize) / macos-job (gh)
RuntimeError: Command bash /Users/runner/work/_temp/exec_script failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / test-models-linux-aarch64 (add_mul, xnnpack-quantization-delegation, linux.arm64.2xlarge) / linux-job (gh) (matched linux rule in flaky-rules.json)
docker: Error response from daemon: Head "https://registry-1.docker.io/v2/arm64v8/alpine/manifests/latest": Get "https://auth.docker.io/token?account=pytorchbot&scope=repository%3Aarm64v8%2Falpine%3Apull&service=registry.docker.io": EOF.

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / test-samsung-models-linux / linux-job (gh) (trunk failure)
test_w2l_fp16
pull / unittest / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / unittest-editable / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
trunk / unittest-release / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

martinlsm · 2026-04-08T11:36:08Z

@pytorchbot ciflow/trunk

pytorch-bot · 2026-04-08T11:36:10Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'ciflow/trunk' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'lint', 'fix-lint', 'apply-lint', 'cherry-pick')

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

martinlsm · 2026-04-08T11:36:15Z

@pytorchbot label "partner: arm"

martinlsm · 2026-04-08T11:36:27Z

@pytorchbot "release notes: none"

pytorch-bot · 2026-04-08T11:36:30Z

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'release notes: none' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'lint', 'fix-lint', 'apply-lint', 'cherry-pick')

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

Copilot

Pull request overview

This PR updates Arm backend pytest naming so tests no longer rely on a _no_target substring for test_arm_baremetal.sh’s non-target suite selection.

Changes:

Renamed many Arm backend tests to remove the _no_target suffix.
Kept target selection behavior driven by pytest -k substrings (e.g., tosa, u55, u85, _vgf_) unchanged.
Updated a copyright header year range in one test file.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
backends/arm/test/quantizer/test_partial_quantization.py	Rename quantizer tests to drop `_no_target`.
backends/arm/test/passes/test_size_adjust_input_pass.py	Rename size-adjust pass tests to drop `_no_target`.
backends/arm/test/passes/test_rewrite_le_lt_to_ge_gt_pass.py	Rename rewrite pass test to drop `_no_target`.
backends/arm/test/passes/test_replace_inf_values_pass.py	Rename ReplaceInf/LimitValues pass tests to drop `_no_target`.
backends/arm/test/passes/test_insert_dynamic_padding_pass.py	Rename dynamic padding test to drop `_no_target`.
backends/arm/test/passes/test_fuse_consecutive_concat_shapes.py	Rename concat-shapes fuse tests to drop `_no_target`.
backends/arm/test/passes/test_decompose_linear_pass.py	Rename linear decomposition test to drop `_no_target`.
backends/arm/test/passes/test_decompose_int16_activation_conv_pass.py	Rename int16-activation conv decomposition test to drop `_no_target`.
backends/arm/test/passes/test_decompose_einsum_pass.py	Rename einsum decomposition test to drop `_no_target`.
backends/arm/test/misc/test_tosa_spec.py	Rename TOSA spec unittest methods to drop `_no_target`.
backends/arm/test/misc/test_tosa_dialect_shape_ops.py	Rename TOSA dialect shape op tests to drop `_no_target`.
backends/arm/test/misc/test_shared_qspecs.py	Rename shared-qspec tests to drop `_no_target`.
backends/arm/test/misc/test_runner_utils.py	Rename runner utils test to drop `_no_target`.
backends/arm/test/misc/test_public_api_manifest.py	Rename public API manifest tests to drop `_no_target`.
backends/arm/test/misc/test_post_quant_device_switch.py	Rename post-quant device-switch test to drop `_no_target`.
backends/arm/test/misc/test_pass_pipeline_config.py	Rename one pass pipeline config test to drop `_no_target`.
backends/arm/test/misc/test_model_evaluator.py	Rename model evaluator unittest methods to drop `_no_target`.
backends/arm/test/misc/test_mixed_fp_bf16_partition.py	Rename mixed fp/bf16 partition tests to drop `_no_target`.
backends/arm/test/misc/test_debug_hook.py	Rename debug hook tests to drop `_no_target` and update copyright header.
backends/arm/test/misc/test_count_tosa_ops.py	Rename TOSA op counting tests to drop `_no_target`.
backends/arm/test/misc/test_const_shape.py	Rename const-shape test to drop `_no_target`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T11:39:19Z

backends/arm/test/misc/test_pass_pipeline_config.py

+def test_pipeline_config_override_outside_compile_spec():
    compile_spec = TosaCompileSpec(
        TosaSpecification.create_from_string("TOSA-1.00+INT")
    )


PR goal is to remove the no_target identifier from Arm backend pytests, but this file still defines test_softmax_config_masked_no_target and test_softmax_config_stable_no_target (lines 42 and 58). Please rename these remaining tests as well to keep naming consistent with the rest of the suite and the PR description.

Copilot · 2026-04-08T11:39:20Z

backends/arm/test/misc/test_post_quant_device_switch.py

 @pytest.mark.parametrize("case", _TEST_CASES, ids=[case.name for case in _TEST_CASES])
-def test_post_quant_device_switch_no_target(case: MetaRetraceCase) -> None:
+def test_post_quant_device_switch(case: MetaRetraceCase) -> None:
    """This test tests that moving a model to another device after quantiation


Typo in the updated docstring: "quantiation" should be "quantization".

Suggested change

"""This test tests that moving a model to another device after quantiation

"""This test tests that moving a model to another device after quantization

martinlsm · 2026-04-09T08:47:18Z

@pytorchbot label ciflow/trunk

martinlsm · 2026-04-09T08:47:28Z

@pytorchbot label "release notes: none"

Copilot AI review requested due to automatic review settings April 8, 2026 11:35

martinlsm requested a review from digantdesai as a code owner April 8, 2026 11:35

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 8, 2026

pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Apr 8, 2026

Copilot started reviewing on behalf of martinlsm April 8, 2026 11:36 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk label Apr 9, 2026

pytorch-bot bot added the release notes: none Do not include this in the release notes label Apr 9, 2026

Merge branch 'main' into remove-no-target

438b600

zingo approved these changes Apr 9, 2026

View reviewed changes

martinlsm merged commit 8df8cfc into pytorch:main Apr 9, 2026
413 of 422 checks passed

martinlsm deleted the remove-no-target branch April 9, 2026 12:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Arm backend: Remove no_target substring for pytests#18769

Arm backend: Remove no_target substring for pytests#18769
martinlsm merged 2 commits intopytorch:mainfrom
martinlsm:remove-no-target

martinlsm commented Apr 8, 2026 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

pytorch-bot bot commented Apr 8, 2026

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

pytorch-bot bot commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

Copilot AI Apr 8, 2026

Uh oh!

martinlsm commented Apr 9, 2026

Uh oh!

martinlsm commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"""This test tests that moving a model to another device after quantiation
	"""This test tests that moving a model to another device after quantization

Conversation

martinlsm commented Apr 8, 2026 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18769

❌ 2 New Failures, 5 Unrelated Failures

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

pytorch-bot bot commented Apr 8, 2026

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

martinlsm commented Apr 8, 2026

Uh oh!

pytorch-bot bot commented Apr 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

martinlsm commented Apr 9, 2026

Uh oh!

martinlsm commented Apr 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

martinlsm commented Apr 8, 2026 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Apr 8, 2026 •

edited

Loading